Upgrade tokio to 1.0 #134
Upgrade tokio to 1.0 #134
Conversation
Tim-Zhang
force-pushed
the
update-tokio-to-1.0
branch
2 times, most recently
from
d464b82
to
6015259
Compare
Tim-Zhang
force-pushed
the
update-tokio-to-1.0
branch
from
6015259
to
580411b
Compare
|
Hey, thanks a lot @Tim-Zhang I'll try to review this week-end! |
There was a problem hiding this comment.
I have read through the patch set, and I can't say that I exactly understand any of it: clearly I need much more knowledge of tokio. It seems that bulk is that: Eventd trait is no more, we go from PollEvented to AsyncFd interface, and that the poll_fn() gets to make use of some refactored changes. The comments at line 66 which go away maybe could be re-interpreted to explain how we use the guard and poll_write_ready() interface so that future maintainers can understand what's going on.
|
@mcr Thank you for your review. The reason I removed the comments at line 66 is that I think the code is clear and obviously, It's a fixed form and document in docs of |
Fixes: little-dude#105 Signed-off-by: Tim Zhang <tim@hyper.sh>
Tim-Zhang
force-pushed
the
update-tokio-to-1.0
branch
from
580411b
to
ef3a79a
Compare
| Err(ref e) if e.kind() == io::ErrorKind::WouldBlock => { | ||
| self.0.clear_write_ready(cx)?; | ||
| Poll::Pending | ||
| loop { |
There was a problem hiding this comment.
Like below, I'm not sure to understand why we need to loop here.
There was a problem hiding this comment.
Looks good to me, I just have a question about the loop that was added to the poll_xxx methods. Thanks for working on this @Tim-Zhang !
|
@little-dude I think we should bump the major version after this pr merged, Because of tokio's upgrade, netlink is not compatible with before |
|
Thanks a ton @Tim-Zhang ! |
Fixes: #105